Open
Conversation
Leo-Berman
force-pushed
the
master
branch
2 times, most recently
from
c074f6b to
b781830
Compare
- Add extractFolderDate to parse YYYY/MM or YYYY/MM/DD from file paths - Sort gallery items by folder date first, then modification timestamp - Group gallery sections by month using folder date when available - Add unit tests for folder date extraction Signed-off-by: Leo Berman <leograntberman@gmail.com>
Signed-off-by: Leo Berman <leograntberman@gmail.com>
Signed-off-by: Leo Berman <leograntberman@gmail.com>
Signed-off-by: Leo Berman <leograntberman@gmail.com>
Author
|
maybe this can't be done in the frontend because if we load by timestamp in the database part then the sections will be loaded weirdly anyways? |
Signed-off-by: Leo Berman <leograntberman@gmail.com>
Author
|
I made a change so it loads everything all at once which saves the categories but I don't really understand exactly the load it places |
|
Cross-linking discussion from forum here: https://help.nextcloud.com/t/first-pull-request-help-regarding-testing/239607 @tobiasKaminsky, maybe you can have a quick look at this if something like it would be a good idea to implement. Then, maybe you could either give some good advice on what is needed to get this merged or what would be needed to have good chances? Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.