Skip to content

fix: show paused status when account has no sync sources#9473

Open
Rello wants to merge 3 commits intomasterfrom
codex/fix-account-status-sync-issue
Open

fix: show paused status when account has no sync sources#9473
Rello wants to merge 3 commits intomasterfrom
codex/fix-account-status-sync-issue

Conversation

@Rello
Copy link
Collaborator

@Rello Rello commented Feb 19, 2026

Motivation

  • The tray window incorrectly displayed “All synced!” for a connected account that had no configured sync folders and no enabled VFS/File Provider, while the tray icon correctly showed the pause state.

Description

  • Add hasConfiguredSyncSource() helper to detect whether the current account has any configured sync folder or an enabled File Provider/VFS domain (guarded by BUILD_FILE_PROVIDER_MODULE).
  • Update setSyncStateToConnectedState() to show “Sync paused” with the pause icon when the account is connected but has no configured sync source instead of reporting “All synced!”.
  • Restrict the initial sync-state evaluation in initSyncState() to only process folders that belong to the active account to avoid unrelated folders affecting the tray summary.
  • Modified file: src/gui/tray/syncstatussummary.cpp.

Testing

  • Attempted to build the macOS target with xcodebuild build -target NextcloudDev, but the command failed in this environment because xcodebuild is not available (bash: command not found: xcodebuild).
  • No other automated test runs were executed in this environment.

Codex Task

Signed-off-by: Rello <Rello@users.noreply.github.com>
@Rello
Copy link
Collaborator Author

Rello commented Feb 19, 2026

Account is connected, but no folder sync nor VFS is enabled. the status is wrong

Bildschirmfoto 2026-02-19 um 08 45 38

@Rello Rello added this to the 33.0.0 milestone Feb 19, 2026
Co-authored-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Co-authored-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
@github-actions
Copy link

Artifact containing the AppImage: nextcloud-appimage-pr-9473.zip

Digest: sha256:e4d4c37a91b7c8961c0fb7d262d140756bbf0b3bd2e9ccd6d49b3495e8c6c9f3

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
3 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments