Fix note creating #2903
Open
Fix note creating #2903
+55
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyScherzinger
force-pushed
the
fixSlowNoteCreating
branch
from
f49fcb8 to
8bba4b3
Compare
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
alperozturk96
force-pushed
the
fixSlowNoteCreating
branch
from
8bba4b3 to
091f085
Compare
alperozturk96
requested changes
Feb 4, 2026
Collaborator
alperozturk96
left a comment
alperozturk96
left a comment
There was a problem hiding this comment.
What issue or bug does this PR fix? What should we test, and how should we test it? Could you share steps to reproduce the issue?
| "on note loaded: updatedNote null : ${newNoteParam == null}; remoteId: ${note.remoteId}" | ||
| ) | ||
|
|
||
| //if (updatedNote != null || updatedNote?.remoteId == null) { |
Collaborator
There was a problem hiding this comment.
Why these logics are disabled?
Contributor
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/2903.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.