refactor(QueryBuilder): Properly type the query builder#57763
Open
CarlSchwan wants to merge 1 commit intomasterfrom
Open
refactor(QueryBuilder): Properly type the query builder#57763CarlSchwan wants to merge 1 commit intomasterfrom
CarlSchwan wants to merge 1 commit intomasterfrom
Conversation
CarlSchwan
added
2. developing
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
CarlSchwan
force-pushed
the
carl/type-querybuilder
branch
7 times, most recently
from
4949aa8 to
27c24e9
Compare
CarlSchwan
force-pushed
the
carl/type-querybuilder
branch
2 times, most recently
from
75af4a1 to
ca05129
Compare
CarlSchwan
added
3. to review
CarlSchwan
requested review from
a team,
SebastianKrupinski and
hamza221
as code owners
CarlSchwan
requested review from
Altahrim,
ArtificialOwl,
icewind1991 and
sorbaugh
and removed request for
a team
come-nc
reviewed
Jan 27, 2026
lib/private/DB/QueryBuilder/ExpressionBuilder/ExpressionBuilder.php
Outdated
Show resolved
Hide resolved
Comment on lines
+258
to
+259
| parent::innerJoin($fromAlias, $join, $alias, $condition); | ||
| return $this; |
Contributor
There was a problem hiding this comment.
I think if you properly type the methods with @return $this in phpdoc you do not need to split all these return parent::… into 2 lines, as $this of self and parent is the same.
| * @param mixed $key The key (index or name) of the bound parameter type. | ||
| * @param int|string $key The key (index or name) of the bound parameter type. | ||
| * | ||
| * @return mixed The value of the bound parameter type. |
Contributor
There was a problem hiding this comment.
I guess it’s the type and not the value?
And probably string|int and not mixed?
CarlSchwan
force-pushed
the
carl/type-querybuilder
branch
2 times, most recently
from
97b14e1 to
efaca86
Compare
And make sure the related unit tests are also typed and checked by psalm. Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/type-querybuilder
branch
from
efaca86 to
4020f91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
3. to review, feature component)stable32)