removal of bugged nf-core utils function call #1116
Merged
TCLamnidis merged 4 commits intodevfrom Feb 28, 2025
Merged
Conversation
|
TCLamnidis
approved these changes
Feb 14, 2025
Co-authored-by: Thiseas C. Lamnidis <thisseass@gmail.com>
jfy133
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call of template nf-core utils template checking of samplesheet is not necessary and currently bugged (behaves incorrectly with https file paths as inputs, raises errors for all other inputs, as expected, but not necessary to raise error).
Solution for nf-core/eager: remove call
Todo: broader fix for deeper nextflow issue, fix nf-core template
Related to #1114
PR checklist
scrape_software_versions.pynf-core lint .).nextflow run . -profile test,docker).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).