Move to nf-core sbwf for GLIMPSE2#240
Merged
LouisLeNezet merged 8 commits intonf-core:devfrom Dec 16, 2025
Merged
Conversation
11 tasks
added 2 commits
December 13, 2025 11:28
atrigila
requested changes
Dec 13, 2025
Comment on lines
+25
to
+26
| ch_chunks | ||
| .filter { _meta, regionin, regionout -> regionin.size() == 0 && regionout.size() == 0 } |
Collaborator
There was a problem hiding this comment.
Current code errors only if all entries are predefined, mixed input (some predefined, some empty) can slip through.
Collaborator
Author
There was a problem hiding this comment.
True, I was thinking of adding a more thorough check during the initialisation process to verify that each channel is properly defined.
This will be done in another PR.
subworkflows/nf-core/bam_vcf_impute_glimpse2/tests/nextflow.config
Outdated
Show resolved
Hide resolved
…nfig Co-authored-by: Anabella Trigila <18577080+atrigila@users.noreply.github.com>
This was
linked to
issues
Dec 15, 2025
atrigila
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Replace #220
Add support for genetic map for GLIMPSE2 imputation.
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).