data set for delly containing INDELS#1322
Open
lindenb wants to merge 3 commits intonf-core:modulesfrom
Open
Conversation
jfy133
reviewed
Sep 13, 2024
Member
jfy133
left a comment
There was a problem hiding this comment.
Hm, I have a few things here:
- The generation READMEs are great, however please also list the files with a short description (exeception: if a file goes
delete_me/) on the main branch top-level README - Illumina is really just a synonym for short reads (depnding on how you simulated your reads)
- File names for the test data (i.e. README is fine but everything else) should be all lower case, and follow the conventions were possible
- E.g.
SAMPLE_DEL.bam->test_del.bam, assuming it's using the original BAMtest.bamfor generation , etc elsetest3_del.bam
- E.g.
- I don't think the
wgsimfolder is necessary, they are still BAM files derived from the 'original' reference genome (even if you've modified the reference slightly ) - For the
dellyfolders, this sounds like they are tool specific and can't be used for other contexts, if so they should go intodelete_me(until we've come up with a better system for that) - otherwise stick to the file-format folders
Author
|
@famosab sorry, I still need this but I don't have the time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed here: https://nfcore.slack.com/archives/C02L5UB4Y9G/p1725656039950949 this is a set of data for delly but it might be also interesting for any SV/DEL application.
It contains a set of BAMS containing a DEL/DUP/INV and WT
As the dataset was not really an illumina dataset, I put things in a wgsim folder.
The Attachment
Makefile.txt
contains the Makefile that was used to generate the data.
while I was here I added a valid gff3 (the gff3 for srarscov in modules is not valid...), a gtf and I called and annotated the 4 bams with bcftools and hapcaller.
Thanks !