Add option to use public_ip as hostname in inventory plugin#116
Open
martialblog wants to merge 1 commit intongine-io:masterfrom
Open
Add option to use public_ip as hostname in inventory plugin#116martialblog wants to merge 1 commit intongine-io:masterfrom
martialblog wants to merge 1 commit intongine-io:masterfrom
Conversation
Author
|
I wasn't sure on how to write a test for that. I'd be happy to add a test if someone could give me a hint. |
Collaborator
|
how does this work with IPV6 as it is introduced in ACS 4.17.x? |
Author
|
I suppose it won't. I specifically named it "v4_public_ip" in order to introduce a v6_public_ip in the future... |
Collaborator
|
My question is that you are using instance.publicip and reexporting it as v4_public_ip. In ACS 4.17 with IPV6 is it not possible that an IPV6 is returned as instance.public ip? Just brainstorming, I have not reviewed the implementation or anything... but perhaps worth double checking... |
resmo
force-pushed
the
master
branch
2 times, most recently
from
2e1f31b to
52fcebc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this would add the option to use the public_ip as a hostname in the inventory plugin.
Cheers,
Markus