Add support for notifying a service#247
Open
njdancer wants to merge 2 commits intonginx-proxy:mainfrom
Open
Conversation
This is useful when deploying stacks as the container_name cannot be set at design time.
|
It works great, thanks. I don't understand why this hasn't been merged already. I would just add this at the beginning of task for iteration body: if task.Status.State != "running" {
continue
}And maybe also say which container the signal could not be sent to: if err := g.Client.KillContainer(killOpts); err != nil {
- log.Printf("Error sending signal to container: %s", err)
+ log.Printf("Error sending signal to container %s: %s", container, err)
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.