Skip to content

Fix incorrect flag in token refresh flow#120

Merged
route443 merged 1 commit intonginxinc:mainfrom
dareste:refresh-token-fix
Feb 11, 2026
Merged

Fix incorrect flag in token refresh flow#120
route443 merged 1 commit intonginxinc:mainfrom
dareste:refresh-token-fix

Conversation

@dareste
Copy link
Contributor

@dareste dareste commented Feb 6, 2026

When refreshing tokens for an existing session, the code is storing session data to the wrong variables (new_session, new_access_token, new_refresh) instead of updating the existing session variables (session_jwt, access_token, refresh_token).

As a result, the existing session does not get the updated tokens, the session continuity breaks and the user is forced to re-authenticate.

The fix is to set isNewSession to false when calling storeSessionDatain the refresh flow.

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@dareste
Copy link
Contributor Author

dareste commented Feb 6, 2026

I have hereby read the F5 CLA and agree to its terms

@route443
Copy link
Contributor

Hi @dareste thanks for reporting! This is a serious issue that appeared after the #108. I added CI and a test that specifically verifies this behavior to prevent it from happening again in the future.

@route443 route443 merged commit c6dc411 into nginxinc:main Feb 11, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants