Fix incorrect flag in token refresh flow#120
Merged
route443 merged 1 commit intonginxinc:mainfrom Feb 11, 2026
Merged
Conversation
|
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
Contributor
Author
|
I have hereby read the F5 CLA and agree to its terms |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When refreshing tokens for an existing session, the code is storing session data to the wrong variables (
new_session,new_access_token,new_refresh) instead of updating the existing session variables (session_jwt,access_token,refresh_token).As a result, the existing session does not get the updated tokens, the session continuity breaks and the user is forced to re-authenticate.
The fix is to set
isNewSessiontofalsewhen callingstoreSessionDatain the refresh flow.