This repository was archived by the owner on Jan 10, 2018. It is now read-only.
Support factory function for _initialState parameter of provideStore#217
Open
iron9light wants to merge 1 commit intongrx:masterfrom
Open
Support factory function for _initialState parameter of provideStore#217iron9light wants to merge 1 commit intongrx:masterfrom
iron9light wants to merge 1 commit intongrx:masterfrom
Conversation
Contributor
|
Can you add an integration test for this? and be sure to squash your commits. |
iron9light
force-pushed
the
patch-1
branch
2 times, most recently
from
9cf8dbc to
181f7be
Compare
ngc does not support function call now. It will be good to support passing a function parameter to provideStore.
Author
|
@robwormald updated based on your comments. |
Member
|
@robwormald is this still valid? |
Contributor
|
this is very much needed. though I am not sure if AoT could be a problem here. |
|
@robwormald could we get this merged please? This PR seems to fix the issues with AoT compilation in the latest Angular 4. I'm trying to use this great lib in a universal app and this PR would help us greatly to move forward. |
|
This is a must have, I dont know why its taking so long for them to merge |
|
It looks that this repo is not maintained any more and the project has move to ngrx/platform. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ngc does not support function call now. It will be good to support passing a function parameter to provideStore.