[Renderers] Extract Clay Renderer API into a separate header file#65
Open
OleksiiBulba wants to merge 7 commits intonicbarker:mainfrom
Open
[Renderers] Extract Clay Renderer API into a separate header file#65OleksiiBulba wants to merge 7 commits intonicbarker:mainfrom
OleksiiBulba wants to merge 7 commits intonicbarker:mainfrom
Conversation
… to follow renderer api
Owner
|
Hello, apologies for the delay, and thank you for this work! This is a great initiative, but it will be important to make sure we really get it right, so I'll leave this one open until we get a couple more renderers into the codebase and we can really see what the shared API surface will look like 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to not depend on the specific renderer I suggest extracting renderer functions into its own header api file. Here what I did:
For Clay_Renderer_Initialize I've created an opaque struct type Clay_Renderer_Data so each renderer can populate its own config: for Raylib it's just window dimensions, title, and flags, for Cairo it's cairo_t type.
I'm not sure if it's ok to modify Cairo renderer, as it has own License notice.