Add public inherent methods to hashing implementation#99
Draft
nickbabcock wants to merge 1 commit intomasterfrom
Draft
Add public inherent methods to hashing implementation#99nickbabcock wants to merge 1 commit intomasterfrom
nickbabcock wants to merge 1 commit intomasterfrom
Conversation
When someone uses a highway hasher without importing the HighwayHash trait, they get a cryptic "private method" error because trait methods aren't available without the trait import and it happens to be that the backing implementation has the same function name. Rust-analyzer shows unhelpful error messages and no quick fixes. This seems less than ideal, so this commit makes implementations public so that the trait import is not needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When someone uses a highway hasher without importing the HighwayHash trait, they get a cryptic "private method" error because trait methods aren't available without the trait import and it happens to be that the backing implementation has the same function name.
Rust-analyzer shows unhelpful error messages and no quick fixes.
This seems less than ideal, so this commit makes implementations public so that the trait import is not needed.