Skip to content

Comments

split favorite channels to own accessor, adds watch next channel to t…#469

Merged
nielsvanvelzen merged 2 commits intonielsvanvelzen:masterfrom
Eightyplus:feature/channels
Jun 16, 2025
Merged

split favorite channels to own accessor, adds watch next channel to t…#469
nielsvanvelzen merged 2 commits intonielsvanvelzen:masterfrom
Eightyplus:feature/channels

Conversation

@Eightyplus
Copy link

@Eightyplus Eightyplus commented Jun 13, 2025

  • split favorite channels to own accessor in view model
  • add watch next row
  • create new WatchNextCardRow

Screenshot_1749802618

Copy link
Owner

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good, I think it makes more sense to add a new "getWatchNextPrograms()" function to ChannelRepository, that is similar to "getProgramsByChannel()" but uses "ChannelResolver.CHANNEL_ID_WATCH_NEXT".

That way you don't need to query all the channels just to pick the one we already know the id of.

@Eightyplus
Copy link
Author

@nielsvanvelzen , hope this looks better 👌

@nielsvanvelzen
Copy link
Owner

I meant to query the programs directly and skip querying the channel, sorry if that wasn't clear! I've added an additional commit to make it behave that way now. Thanks for the contribution!

@nielsvanvelzen nielsvanvelzen merged commit a1b720b into nielsvanvelzen:master Jun 16, 2025
@Eightyplus
Copy link
Author

I meant to query the programs directly and skip querying the channel, sorry if that wasn't clear! I've added an additional commit to make it behave that way now. Thanks for the contribution!

Understandably, since the code is new to me, but that was cleaner code 👍
Glad I can contribute 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants