Add option to disable recursive refs in Name Resolution#1075
Draft
dhaeckel wants to merge 2 commits intonikic:masterfrom
Draft
Add option to disable recursive refs in Name Resolution#1075dhaeckel wants to merge 2 commits intonikic:masterfrom
dhaeckel wants to merge 2 commits intonikic:masterfrom
Conversation
Breaks json encoding of nodes
Owner
|
Hm, I wonder if we should just always do the clone if replaceNodes is disabled, rather than introduce an additional option. |
Author
|
Happy to change the PR accordingly, although @theofidry raised the concern of higher memory consumption in this case. This would impact all apps that use replaceNodes = false. I can't really tell, if this is a problematic impact or negligible. I'll leave it up to you, which way you prefer. |
Author
|
Hi @nikic, do you have any opinion on how to go forward with this? I'm happy with any of the two solutions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.