-
Notifications
You must be signed in to change notification settings - Fork 308
ENH: Add descriptions.tsv for BIDS derivatives #3591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Generate a descriptions.tsv file documenting the processing procedures associated with each desc- entity value used in fMRIPrep derivatives, following the BIDS common derivatives specification. Key features: - Procedure-focused descriptions explain what processing was performed - Dynamic generation: steps only listed if actually applied (e.g., SDC omitted when no fieldmaps available) - Parameters column captures thresholds and settings used - Covers both data files (preproc, brain, hmc) and report figures 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Update CircleCI expected output files to include the new descriptions.tsv file that documents desc- entity procedures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
fmriprep/tests/test_descriptions.py
Outdated
| from fmriprep.utils.bids import write_descriptions_tsv | ||
|
|
||
|
|
||
| @pytest.mark.ai_generated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, this is my convention to annotate AI produced unittests since often they are not "as good" as human curated and might require either consolidation or just more careful review to see if worthy
- Prefix unused unpacked variables with underscore - Split compound assertion into separate assertions - Apply ruff formatting fixes 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3591 +/- ##
==========================================
+ Coverage 72.88% 73.47% +0.58%
==========================================
Files 60 61 +1
Lines 4821 4984 +163
Branches 626 655 +29
==========================================
+ Hits 3514 3662 +148
- Misses 1164 1171 +7
- Partials 143 151 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The project uses --strict-markers, so unregistered markers cause errors. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Changes proposed in this pull request
This PR adds support for generating a
descriptions.tsvfile at the derivatives root level, following the BIDS common derivatives specification.What it does
fMRIPrep produces outputs with
_desc-entities (e.g.,desc-preproc,desc-brain,desc-hmc) but previously lacked documentation of what these descriptions mean. This PR adds:fmriprep/data/descriptions.json- Template definitions for alldesc-entities with:_suffix)fmriprep/utils/bids.py- Newwrite_descriptions_tsv()function that:parameterscolumn with thresholds and settings usedIntegration in
fmriprep/cli/run.py- Writesdescriptions.tsvalongsidedataset_description.jsonExample output
With full preprocessing (SDC + STC):
Without SDC/STC:
Tests
Documentation that should be reviewed
The
descriptions.tsvoutput format follows BIDS conventions. No documentation changes are included in this PR, but the output files are self-documenting.