WIP: FIX: Fix multi-voxel DTI fitting#410
Draft
jhlegarreta wants to merge 1 commit intonipreps:mainfrom
Draft
Conversation
This was referenced Jan 24, 2026
Merged
jhlegarreta
force-pushed
the
fix/fix-multivoxel-dti-fit
branch
from
010f911 to
50498b7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #410 +/- ##
==========================================
+ Coverage 83.04% 83.14% +0.09%
==========================================
Files 37 37
Lines 2070 2070
Branches 228 228
==========================================
+ Hits 1719 1721 +2
+ Misses 307 306 -1
+ Partials 44 43 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jhlegarreta
force-pushed
the
fix/fix-multivoxel-dti-fit
branch
from
50498b7 to
7924e19
Compare
Fix multi-voxel DTI fitting. Add the corresponding tests.
jhlegarreta
force-pushed
the
fix/fix-multivoxel-dti-fit
branch
from
7924e19 to
0f652aa
Compare
Contributor
Author
|
DKI multi-voxel fit branch: https://github.com/jhlegarreta/nifreeze/tree/fix/fix-dki-multivoxel-fit |
Contributor
Author
|
Looks like the issue is in our side rather than anywhere else: Tests in that gist are passing: using a multi-voxel 3D arrangement vs a flattened array provide the same results in DIPY. I confess that I have not investigated this further, or have not closely inspected things. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix multi-voxel DTI fitting.
Add the corresponding tests.