metrics: convert from CommonJS to ES Modules#3830
Open
trivikr wants to merge 1 commit intonodejs:mainfrom
Open
metrics: convert from CommonJS to ES Modules#3830trivikr wants to merge 1 commit intonodejs:mainfrom
trivikr wants to merge 1 commit intonodejs:mainfrom
Conversation
targos
approved these changes
Jul 14, 2024
Member
Author
|
This PR has been open for 72+ weekend hours, and is ready to merge. |
Member
Author
|
cc @nodejs/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the scripts in metrics from CommonJS to ES Modules
Part of modernizing metrics scripts as a follow-up to #3697
Testing
The ESM setup was deployed on processlogs, and verified that logs are being processed
Before
After