update.sh: remove unnecessary rm operation #2371
Open
+0
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change was added in https://github.com/nodejs/docker-node/pull/757/changes but I can't see any reason why this piece of code would be executed. The sed command used includes
-iwhich isn't a POSIX standard operation and this code appears to be removing a temporary file that is never actually created because of the use of-i.Would be good if someone on a mac could verify this since that seems to be the platform that resulted in the
-eparameter being added.Motivation and Context
Testing Details
I've ran
update.shand no-tmp-efiles were left behindExample Output(if appropriate)
Types of changes
Checklist