Skip to content

Conversation

@sxa
Copy link
Member

@sxa sxa commented Feb 3, 2026

Description

This change was added in https://github.com/nodejs/docker-node/pull/757/changes but I can't see any reason why this piece of code would be executed. The sed command used includes -i which isn't a POSIX standard operation and this code appears to be removing a temporary file that is never actually created because of the use of -i.

Would be good if someone on a mac could verify this since that seems to be the platform that resulted in the -e parameter being added.

Motivation and Context

Testing Details

I've ran update.sh and no -tmp-e files were left behind

Example Output(if appropriate)

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (none of the above) - obsolete code

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

Signed-off-by: Stewart X Addison <sxa@ibm.com>
@sxa
Copy link
Member Author

sxa commented Feb 3, 2026

I can't explicitly add reviewers so tagging @PeterDaveHello who did the referenced PR that introduced these lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant