Skip to content

Fix incorrect instruction in cmake.js docs#1632

Merged
legendecas merged 1 commit intonodejs:mainfrom
segevfiner:patch-1
Feb 10, 2025
Merged

Fix incorrect instruction in cmake.js docs#1632
legendecas merged 1 commit intonodejs:mainfrom
segevfiner:patch-1

Conversation

@segevfiner
Copy link
Contributor

No description provided.

@legendecas
Copy link
Member

CI failures should be fixed by #1634.

@mhdawson
Copy link
Member

mhdawson commented Feb 7, 2025

@segevfiner could you rebase to the current main branch as it needs a fix that has been landed since you opened it to be able to pass the tests.

@segevfiner
Copy link
Contributor Author

@segevfiner could you rebase to the current main branch as it needs a fix that has been landed since you opened it to be able to pass the tests.

Rebased.

@legendecas legendecas merged commit 31c4a88 into nodejs:main Feb 10, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants