-
-
Notifications
You must be signed in to change notification settings - Fork 34.6k
src: allow empty --experimental-config-file #61610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Review requested:
|
775234b to
9b00ced
Compare
pmarchini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61610 +/- ##
==========================================
- Coverage 89.76% 89.75% -0.01%
==========================================
Files 673 674 +1
Lines 203944 204404 +460
Branches 39191 39275 +84
==========================================
+ Hits 183080 183473 +393
- Misses 13194 13236 +42
- Partials 7670 7695 +25
🚀 New features to boost your workflow:
|
3dc9b42 to
2356e3a
Compare
| ['--experimental-config-file', 'node.config.json', ''], | ||
| ['--experimental-default-config-file', '', false], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we removing those entries in the test?
2356e3a to
e53ba12
Compare
This PR makes
--experimental-config-fileaccept no arg.When no arg is passed, it will default to
node.config.json.--experimental-default-config-fileis just an alias of--experimental-config-file.The reason for this change is so when stable we can just remove
--experimental-default-config-fileand rename--experimental-config-fileto--config-file.Users can execute node with
node --config-file index.jsornode --config-file=foo.json index.js.