Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes Istanbul coverage ignore comments throughout the codebase, as the project has moved from Istanbul to c8 for test coverage and no longer targets 100% coverage.
- Removes outdated Istanbul ignore comments from across multiple files
- Cleans up legacy code coverage instrumentation directives
- Aligns with the project's current testing approach using c8 instead of Istanbul
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/generate-pem.js | Removes Istanbul ignore file directive |
| lib/dispatcher/client.js | Removes Istanbul ignore comment for test-only method |
| lib/dispatcher/client-h2.js | Removes Istanbul ignore comment from assertion logic |
| lib/dispatcher/client-h1.js | Removes multiple Istanbul ignore comments from error handling, timeout logic, and WASM fallback code |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
gurgunday
approved these changes
Sep 21, 2025
Merged
slagiewka
pushed a commit
to slagiewka/undici
that referenced
this pull request
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we dont use istanbul but c8, but anyway we dont try to target 100% test coverage.
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status