[WIP] Feature/add community groups#536
[WIP] Feature/add community groups#536jpwesselink wants to merge 3 commits intonodeschool:sourcefrom
Conversation
community-groups.html
Outdated
| <link rel="stylesheet" href="/style.css"> | ||
| <link rel="stylesheet" href="/community-groups.css"> | ||
| <link rel="shortcut icon" href="/favicon.ico"> | ||
| <link href="http://fonts.googleapis.com/css?family=Source+Sans+Pro:400,700|Source+Code+Pro" rel="stylesheet" type="text/css"> |
There was a problem hiding this comment.
replace with <link href="//fonts.googleapis.com/css?family=Source+Sans+Pro:400,700|Source+Code+Pro" rel="stylesheet" type="text/css">
There was a problem hiding this comment.
Yah, should have rebased yesterday
| <div class="two-thirds"> | ||
| <ul> | ||
| <li><strong data-i18n="footer-contact-header">Contact</strong></li> | ||
| <li><a href="https://twitter.com/nodeschool" target="_blank">t/@nodeschool</a></li> |
There was a problem hiding this comment.
we should use rel="noreferrer noopener" on _blank targets for security reasons
| <ul> | ||
| <li><strong data-i18n="footer-contact-header">Contact</strong></li> | ||
| <li><a href="https://twitter.com/nodeschool" target="_blank">t/@nodeschool</a></li> | ||
| <li><a href="https://github.com/nodeschool" target="_blank">gh/nodeschool</a></li> |
| </ul> | ||
| <ul> | ||
| <li><strong data-i18n="footer-contribute-header">Contribute</strong></li> | ||
| <li><a href="https://github.com/nodeschool/discussions/issues/new" target="_blank" data-i18n="footer-contribute-question">Open an Issue</a></li> |
| <ul> | ||
| <li><strong data-i18n="footer-contribute-header">Contribute</strong></li> | ||
| <li><a href="https://github.com/nodeschool/discussions/issues/new" target="_blank" data-i18n="footer-contribute-question">Open an Issue</a></li> | ||
| <li><a href="https://github.com/nodeschool/discussions/issues" target="_blank" data-i18n="footer-contribute-answer">Answer a Question</a></li> |
community-groups/military.json
Outdated
| "organizers": ["hollomancer"], | ||
| "website": "", | ||
| "twitter": "", | ||
| "repo": "http://github.com/nodeschool/military-community-group" |
There was a problem hiding this comment.
repo should point to https version by default
| const mkdirp = require('mkdirp') | ||
|
|
||
| function groupByValue(list, grouper, groupName) { | ||
| var grouped = {} |
There was a problem hiding this comment.
any reason why we choose to use semicolons for some portions but not for others?
There was a problem hiding this comment.
This goes beyond this PR imho
There was a problem hiding this comment.
i agree. thanks for opening #537. we should follow one style
|
I think it is not necessary (feasible) to wait for the translations before we can merge this. |
jpwesselink
force-pushed
the
feature/add-community-groups
branch
from
f459fc5 to
308a584
Compare
jpwesselink
force-pushed
the
feature/add-community-groups
branch
from
308a584 to
76b232e
Compare
3 participants
#533
Translations