server: block server access via non-local domains#3587
Open
cebtenzzre wants to merge 3 commits intomainfrom
Open
server: block server access via non-local domains#3587cebtenzzre wants to merge 3 commits intomainfrom
cebtenzzre wants to merge 3 commits intomainfrom
Conversation
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
314b589 to
86326bb
Compare
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Member
Author
|
If you add $ curl 'http://localhost:4891/v1/models'
{"data": ...}
$ curl 'http://example.com:4891/v1/models'
{"error":"Access to the server via non-local host example.com is forbidden."}This also makes it more difficult to expose the local server to the internet, which I believe is a good thing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the necessary code to prevent a potential DNS rebind attack of the local server, in which a malicious remote host points their domain name to a local IP address to bypass CORS, allowing a client-side script in a web browser to access the local GPT4All instance. This is exacerbated by the fact that the local server currently provides no authentication mechanism.
TODO: Test this change.done.