Setting precision for all calculations#10
Open
twoletters wants to merge 3 commits intonomuramasahir0:masterfrom
Open
Setting precision for all calculations#10twoletters wants to merge 3 commits intonomuramasahir0:masterfrom
twoletters wants to merge 3 commits intonomuramasahir0:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NumPy defaults to float64 on modern systems. It can sometimes be convenient to decrease precision to float32 to limit the memory footprint and speed up calculations, or to increase it to float128 for precise calculations. This PR used a few hacks to keep the code as clean as possible. Please double-check and test all calculations, as I reordered some elements and modified many.
Specifying a type is optional and can be achieved by adding parameter
dtypeto theCRFMNESconstructor:For convenience, a Dockerfile and updated dependencies are also provided.