[WIP] Feature/better front controller#263
Open
shaoshiva wants to merge 28 commits intonovius-os:master/elchefrom
Open
[WIP] Feature/better front controller#263shaoshiva wants to merge 28 commits intonovius-os:master/elchefrom
shaoshiva wants to merge 28 commits intonovius-os:master/elchefrom
Conversation
This refactoring has not already been tested, it's juste a prototype.
jguyomard
force-pushed
the
master/elche
branch
from
b52d845 to
9631c5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a full refactoring of the front controller with the minimum of breaking change.
The first idea of this PR is to make the code more readable and understandable (better design, code style and modularity...).
The second idea of this PR is to implement the possibility to alter the front routing mechanism, like adding custom routes that are not based on the page structure.