Show local cursor and cursor while dragging the clip area#1991
Draft
redneck-f25 wants to merge 4 commits intonovnc:masterfrom
Draft
Show local cursor and cursor while dragging the clip area#1991redneck-f25 wants to merge 4 commits intonovnc:masterfrom
redneck-f25 wants to merge 4 commits intonovnc:masterfrom
Conversation
Member
|
Disabling the local cursor is discussed in #974 and #1684, and my stance is still that I don't think it's appropriate in noVNC. Allowing a different fallback cursor is perfectly okay, though. TigerVNC recently added the option of choosing between the dot cursor and the standard system cursor. Switching to a drag cursor whilst dragging seems natural enough that I think we can do that implicitly, without a setting. |
Author
|
There is a cleaned up separate PR for the drag-cursor part #1992. The local cursor in view-only or with buggy servers is another thing and it's not done the mentioned disuccions. I'll think about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes it's hard to see the small dot if there is no remote cursor, i. e. if in view-only mode.
Add option
show_local_cursorto show the local cursor while the mouse is over the canvas.Add option
show_drag_cursorto showgraborgrabbingcursor while in drag mode ore while dragging.Preview: https://download.bitctrl.de/novnc-u6Nm/noVNC-feature-local-cursors/vnc.html?show_local_cursor=1&show_drag_cursor=1&show_dot=1&view_clip=1&view_only=1
See discussion at #1986
EDIT: To see the first seconds of the video below, you may need to open it in another tab (at least in Chrome on Windows).
cursors-h264-full.mp4