Add missing fields for Update SubscriberCredentials Request#135
Add missing fields for Update SubscriberCredentials Request#135jainpawan21 merged 1 commit intomainfrom
Conversation
WalkthroughThe changes introduce new fields to two classes: Changes
Assessment against linked issues
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/main/java/co/novu/api/subscribers/requests/UpdateSubscriberCredentialsRequest.java (1)
10-10: Document and test the newintegrationIdentifierfield
Please update your API documentation and add unit/integration tests to cover the newintegrationIdentifierproperty, ensuring it’s serialized/deserialized correctly (e.g., with@JsonPropertyif required by your JSON mapper).src/main/java/co/novu/api/subscribers/pojos/ChannelCredentials.java (1)
12-16: Add serialization mappings and tests for the new metadata fields
The fieldsalertUid,title,imageUrl,state, andexternalUrlneed JSON mapping, documentation updates, and unit tests to validate serialization/deserialization (consider@JsonProperty/@JsonIncludeas needed).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/main/java/co/novu/api/subscribers/pojos/ChannelCredentials.java(1 hunks)src/main/java/co/novu/api/subscribers/requests/UpdateSubscriberCredentialsRequest.java(1 hunks)
Closes #134
Summary by CodeRabbit