fix: do not switch to git+ssh for https repository links #434
+11
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
changed the title
When the URL explicitly contains https, do not try to switch to ssh. This change is necessary for [npm][3] to retain the protocol, please see the link and the referenced issues [here][1] and [here][2] reporting problems when using ssh instead of requested https. [1]: npm/cli#2610 [2]: npm/cli#4305 [3]: npm/cli#8703 Signed-off-by: Oldřich Jedlička <oldium.pro@gmail.com>
oldium
force-pushed
the
fix/git-https
branch
from
a200ae9 to
37f4bf5
Compare
Author
|
Rebased to latest main |
Member
|
This kind of change is one that is likely going to need to be a semver major one, out of an abundance of caution. It looks good as-is, but historically this kind of change is pretty disruptive in places we don't expect. We will keep this PR open, and I have added it to the future changes tracking issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the URL explicitly contains https, do not try to switch to ssh. This change is necessary for npm to retain the protocol, please see the link and the referenced issues here and here reporting problems when using ssh instead of requested https.
References
Relates to npm/cli#8703