Skip to content

feat: rate limit translation#1213

Closed
johnnyreilly wants to merge 5 commits intonpmx-dev:mainfrom
johnnyreilly:rate-limit-translation
Closed

feat: rate limit translation#1213
johnnyreilly wants to merge 5 commits intonpmx-dev:mainfrom
johnnyreilly:rate-limit-translation

Conversation

@johnnyreilly
Copy link
Contributor

This is a follow on to #1200 and also resolves: #1174

This adds internationalisation translations for the rate_limited key. I cannot claim to know the translations are correct - they were generated by AI. I remain relatively optimistic they'll be good enough though.

@vercel
Copy link

vercel bot commented Feb 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Feb 8, 2026 6:59pm
npmx.dev Ready Ready Preview, Comment Feb 8, 2026 6:59pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Feb 8, 2026 6:59pm

Request Review

@github-actions
Copy link

github-actions bot commented Feb 8, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/ar-EG.json Localization changed, will be marked as complete. 🔄️
lunaria/files/az-AZ.json Localization changed, will be marked as complete. 🔄️
lunaria/files/cs-CZ.json Localization changed, will be marked as complete. 🔄️
lunaria/files/de-DE.json Localization changed, will be marked as complete. 🔄️
lunaria/files/es-419.json Localization changed, will be marked as complete. 🔄️
lunaria/files/es-ES.json Localization changed, will be marked as complete. 🔄️
lunaria/files/fr-FR.json Localization changed, will be marked as complete. 🔄️
lunaria/files/hi-IN.json Localization changed, will be marked as complete. 🔄️
lunaria/files/hu-HU.json Localization changed, will be marked as complete. 🔄️
lunaria/files/id-ID.json Localization changed, will be marked as complete. 🔄️
lunaria/files/ja-JP.json Localization changed, will be marked as complete. 🔄️
lunaria/files/mr-IN.json Localization changed, will be marked as complete. 🔄️
lunaria/files/ne-NP.json Localization changed, will be marked as complete. 🔄️
lunaria/files/no-NO.json Localization changed, will be marked as complete. 🔄️
lunaria/files/pl-PL.json Localization changed, will be marked as complete. 🔄️
lunaria/files/pt-BR.json Localization changed, will be marked as complete. 🔄️
lunaria/files/ru-RU.json Localization changed, will be marked as complete. 🔄️
lunaria/files/te-IN.json Localization changed, will be marked as complete. 🔄️
lunaria/files/uk-UA.json Localization changed, will be marked as complete. 🔄️
lunaria/files/zh-CN.json Localization changed, will be marked as complete. 🔄️
lunaria/files/zh-TW.json Localization changed, will be marked as complete. 🔄️
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov
Copy link

codecov bot commented Feb 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 8, 2026

📝 Walkthrough

Walkthrough

This pull request adds the translation key rate_limited across 30+ locale files in both the i18n/locales/ and lunaria/files/ directories. Each locale receives a localised message indicating that npm request rate limits have been reached, with instructions to retry. The addition extends the search-related translation strings without modifying existing keys or altering control flow logic.

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The PR description clearly relates to the changeset, explaining that it adds internationalisation translations for the rate_limited key as a follow-up to #1200 and resolution of #1174.
Linked Issues check ✅ Passed The PR adds rate_limited translation strings across 40+ locale files (both i18n and lunaria directories), directly addressing the objective from #1174 to surface and handle rate-limited responses in the UI by providing localised user feedback.
Out of Scope Changes check ✅ Passed All changes are strictly limited to adding rate_limited translation entries across locale files. No unrelated changes, code logic modifications, or out-of-scope files are present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@ghostdevv ghostdevv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now we wanna limit AI translations since we don't have a good way for those who speak the language to come in and fix them without having to read the whole thing or carefully watch the diffs - I'll close this for now 🙏 Thank you for contributing though! Let me know if I can help with anything else you want to work on ❤️

@ghostdevv ghostdevv closed this Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search results not appearing due to rate limiting / 429s

2 participants