Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
📝 WalkthroughWalkthroughAdds a keyboard shortcuts modal to AppFooter.vue. Introduces a 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
app/components/AppFooter.vue (2)
103-110: Addaria-modalfor the dialog.Helps assistive tech treat this as a true modal.
✅ Suggested tweak
- role="dialog" + role="dialog" + aria-modal="true"
115-121: Prefer colon-syntax for the icon class.Use the preset-icons colon form to keep resolution consistent.
♻️ Suggested change
- <span aria-hidden="true" class="size-5 i-lucide-x" /> + <span aria-hidden="true" class="size-5 i-lucide:x" />Based on learnings, “prefer colon-syntax for icons (e.g., i-carbon:checkmark) over the dash-separated form … apply this pattern to all Vue components.”
|
@danielroe I have no idea what I am doing but take a look now. |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
app/components/AppFooter.vue (1)
95-148: Consider extracting repeatedkbdstyling into a utility class.The same
kbdstyling (items-center justify-center text-sm text-fg bg-bg-muted border border-border rounded px-2) is repeated nine times. Extracting this to a utility class or UnoCSS shortcut would reduce duplication and ease future style changes.♻️ Example approach
In your UnoCSS config, define a shortcut:
shortcuts: { 'kbd-key': 'items-center justify-center text-sm text-fg bg-bg-muted border border-border rounded px-2', }Then simplify each
<kbd>:- <kbd - class="items-center justify-center text-sm text-fg bg-bg-muted border border-border rounded px-2" - >,</kbd> + <kbd class="kbd-key">,</kbd>
|
@ghostdevv I did think about this but
|
|
we already have |
|
Thank you for cleaning up my nonsense @danielroe |
I guess I should put this in the shortcut modal? |
|
not nonsense at all! and still wondering whether I should not have removed |
|
I'm updating the content atm - will push and you can edit/remove |
|
@danielroe I approve your addition |
|
🤝 |
|
@ghostdevv are you happy to proceed without a shortcut for the shortcuts for now? |
|
@ghostdevv I'm gonna merge this and we can add something else later if desired. |
We can add another kb shortcut later on if desired.
ah nice! It looks like github uses that to show the modal, so I wonder if we should too - Discord uses |
ahhh sorry! only just seeing this - happy to createa a follow up pr if we reach a consensus |
I'm not sure how good this is.
Initially thought about using native HTML popover etc, but thought I would try and make it more Vue like.
Closes #1111