fix: show info-tooltips on mobile#1268
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThis pull request refactors tooltip implementation across three package-related components (Dependencies.vue, InstallScripts.vue, and SkillsModal.vue) by replacing inline span wrappers with TooltipApp components. Concurrently, the Tooltip base components are enhanced with a new Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Comment |
Since we only used the title, it didn't work on mobile devices if the element wasn't clickable. I used Tooltip instead of title in icon-only notes.
I also added an invisible padding in these places to increase the tap size to 32x32 (a good practice for a11y)
I also added the ability to specify a container in
TooltipBase, since dialogs have their own layer (:top-layer) and elements in the body will always be below itCloses #511