feat: add watermark on chart SVG and PNG prints#1269
feat: add watermark on chart SVG and PNG prints#1269graphieros merged 4 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThis PR updates the DownloadAnalytics component to add SVG/PNG export helpers (print legend and npmx watermark), adjust chart rendering and layout (bottom padding, horizontal grid lines, x‑axis label modulo, yearly/monthly overlays), bind minimap visibility to series length, switch to a single‑series legend in non‑multi‑package mode, extend CSS variable usage (adding --fg-muted), and add print‑specific CSS overrides. It also injects the legend and watermark into the SVG/PNG export flow and bumps Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
app/components/Package/DownloadAnalytics.vue (1)
1483-1485: Consider dynamic modulo based on granularity.The hardcoded
modulo: 12shows labels every 12 datapoints, which works well for monthly data (yearly intervals) but may be less intuitive for daily granularity (every 12 days).💡 Optional: Dynamic modulo based on granularity
xAxisLabels: { show: true, showOnlyAtModulo: true, - modulo: 12, + modulo: displayedGranularity.value === 'daily' ? 7 : 12,This would show daily labels weekly (every 7 days) while keeping the 12-interval for other granularities.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Closes #1197