-
-
Notifications
You must be signed in to change notification settings - Fork 192
fix(i18n): various rtl and arabic fixes #760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
this is mostly a workaround, a proper fix is needed.
|
I was going to start fixing some RTL issues, and some Arabic-specific things like the font. But I couldn't make the font work only for Arabic text, especially when there's English words (the original English font will not be used). I also wanted to fix the code section because it doesn't have to be RTL 😅 though I faced many issues with font and other weird bugs so I ditched the idea. Are you gonna work on any of those fixes? |
|
Oh yes, already switched the code portions to be LTR and made the README direction automatic among others, but haven't committed yet. Hopefully will add a few other things in this PR today, mostly layout fixes and other minor things. As for adding a font for Arabic, we should have that as a separate PR. Feel free to open one if you manage to get it working! Ideally we want it to act as a "fallback", where the original font is prioritized but missing glyphs fall back onto the Arabic font. Not sure how feasible that is in the web, will hopefully look into it after this. |
Fixing various RTL issues:
built_atstring....with…to avoid odd ligature behavior, at least until a proper fix is implemented.Draft, will commit more fixes so it's all merged in one go.