Skip to content

Conversation

@AgentEnder
Copy link
Member

Current Behavior

There's a bug currently where is a plugin returns a dependsOn dependency or input that directly references another project by name, and a later plugin renames that project, the dependsOn or input entry is left stale and pointing at a now non-existent project.

Expected Behavior

The old refs are kept up to date as the nodes get merged together

AI Summary

This pull request introduces a new mechanism to handle project name substitutions in the Nx project graph, ensuring that references to project names in inputs and dependsOn blocks remain accurate even if a plugin changes a project's name during graph construction. The main addition is the ProjectNameInNodePropsManager, which tracks and updates references when project names change. Several related refactorings and improvements were made to integrate this manager into the project configuration merging process.

Project name substitution and consistency:

  • Added a new ProjectNameInNodePropsManager class to manage and apply project name substitutions when project names change, ensuring that all references in inputs and dependsOn blocks remain consistent.
  • Integrated the ProjectNameInNodePropsManager into the mergeCreateNodesResults function, registering substitutors for node results, marking roots as dirty when names change, and applying substitutions after merging. [1] [2] [3]

API and function changes:

  • Modified mergeProjectConfigurationIntoRootMap to return an object indicating whether a project name was changed, instead of just returning void. [1] [2]

Code organization and import cleanup:

  • Refactored imports in project-configuration-utils.ts for better organization and to accommodate the new manager. [1] [2]

@vercel
Copy link

vercel bot commented Feb 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nx-dev Ready Ready Preview Feb 4, 2026 8:52pm

Request Review

@nx-cloud
Copy link
Contributor

nx-cloud bot commented Feb 4, 2026

View your CI Pipeline Execution ↗ for commit 71a0422

Command Status Duration Result
nx affected --targets=lint,test,test-kt,build,e... ⏳ In Progress ... View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 4m 4s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 7s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-02-13 01:52:02 UTC

@netlify
Copy link

netlify bot commented Feb 4, 2026

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit 71a0422
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/698e81c6a077b400081b8ff2
😎 Deploy Preview https://deploy-preview-34332--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 4, 2026

Deploy Preview for nx-dev ready!

Name Link
🔨 Latest commit 71a0422
🔍 Latest deploy log https://app.netlify.com/projects/nx-dev/deploys/698e81c6748195000869c097
😎 Deploy Preview https://deploy-preview-34332--nx-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@nx-cloud nx-cloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

A new CI pipeline execution was requested that may update the conclusion below...

Nx Cloud has identified a possible root cause for your failed CI:

These Gradle e2e test failures are caused by an external infrastructure issue, not the PR changes. The foojay toolchain resolver API is returning 503 Service Temporarily Unavailable errors when Gradle attempts to download Java 21, preventing builds from completing. This is unrelated to our project name substitution changes in the core Nx project graph utilities.

No code changes were suggested for this issue.

Trigger a rerun:

Rerun CI

Nx Cloud View detailed reasoning on Nx Cloud ↗


🎓 Learn more about Self-Healing CI on nx.dev

@AgentEnder AgentEnder force-pushed the fix/stable-project-refs-in-deps-and-inputs branch from ba435cc to 615e53a Compare February 11, 2026 19:39
@AgentEnder AgentEnder force-pushed the fix/stable-project-refs-in-deps-and-inputs branch from 615e53a to 71a0422 Compare February 13, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant