This repository was archived by the owner on Aug 30, 2025. It is now read-only.
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Benchstat Geomean Results1.14% sec/op, -0.00% B/op, 0.00% allocs/op Benchstat results |
nickzelei
approved these changes
Apr 8, 2025
Member
nickzelei
left a comment
nickzelei
left a comment
There was a problem hiding this comment.
LGTM, left a comment regarding supported types.
| return v, nil | ||
| case []byte: | ||
| return string(v), nil | ||
| // todo: handle more types |
Member
There was a problem hiding this comment.
Would it be difficult to fill in more types here? Ideally this thing works for any type and we can allow it for any or most data types. Unclear how this will appear on the FE atm though.
Member
There was a problem hiding this comment.
I'm moreso wondering fi there is a way to effectively cast any input type to either []byte or string. Whichever is the most convenient for passing in to a hash function. You can hash anything if it's a []byte...maybe casting to string is not the best approach.
nickzelei
reviewed
Apr 8, 2025
| } | ||
|
|
||
| func hashToString(hasher hash.Hash, input string) (string, error) { | ||
| _, err := hasher.Write([]byte(input)) |
Member
There was a problem hiding this comment.
maybe it's better to make the input a []byte then we just convert the value any to a []bte, then we support everything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.