fix: updated build.gradle regex for expo project#122
Open
vinhnt08 wants to merge 1 commit intonumandev1:mainfrom
Open
fix: updated build.gradle regex for expo project#122vinhnt08 wants to merge 1 commit intonumandev1:mainfrom
vinhnt08 wants to merge 1 commit intonumandev1:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In Expo SDK 54 and React Native 0.81.5, the Gradle configuration key
enableProguardInReleaseBuildshas been replaced withenableMinifyInReleaseBuilds. Because of this change, the plugin’s regex no longer matches the expected line inside app/build.gradle duringexpo prebuild, causing the plugin to skip injecting the required configuration.This update modifies the regex to match the new key so that the plugin correctly generates the expected Gradle code again.
Changelog
Test Plan