Skip to content

feat(test): a simple in-memory buffer for simulating ISB#3213

Open
vigith wants to merge 4 commits intomainfrom
inmemory-isb-framework
Open

feat(test): a simple in-memory buffer for simulating ISB#3213
vigith wants to merge 4 commits intomainfrom
inmemory-isb-framework

Conversation

@vigith
Copy link
Member

@vigith vigith commented Feb 8, 2026

Closes #3198

Signed-off-by: Vigith Maurice <vigith@gmail.com>
@vigith vigith requested review from whynowy and yhl25 as code owners February 8, 2026 18:17
Signed-off-by: Vigith Maurice <vigith@gmail.com>
@codecov
Copy link

codecov bot commented Feb 8, 2026

Codecov Report

❌ Patch coverage is 98.67424% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.61%. Comparing base (dbdfdbd) to head (4098879).

Files with missing lines Patch % Lines
rust/numaflow-testing/src/simplebuffer.rs 94.71% 12 Missing ⚠️
rust/numaflow-testing/src/simplebuffer/reader.rs 99.53% 1 Missing ⚠️
rust/numaflow-testing/src/simplebuffer/writer.rs 99.55% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3213      +/-   ##
==========================================
+ Coverage   80.26%   80.61%   +0.34%     
==========================================
  Files         297      302       +5     
  Lines       67629    68685    +1056     
==========================================
+ Hits        54283    55367    +1084     
+ Misses      12796    12765      -31     
- Partials      550      553       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Vigith Maurice <vigith@gmail.com>
Signed-off-by: Vigith Maurice <vigith@gmail.com>
Copy link
Contributor

@yhl25 yhl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make write method return a future and resolve it using resolve method? Also let's make sure we can inject errors for during future resolution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

inmemory ISB for testing

2 participants