Commandline parsing to get basic information about the app#734
Commandline parsing to get basic information about the app#734
Conversation
|
I really like this! I can't think of any other command line switches we could add at the moment, but I like the ones you came up with. For the I'd also add the Qt version there (build version + runtime version), similarly to what we already do in the about window, e.g.: I like showing both Qt versions because since we unfortunately rely on private Qt headers, having mismatched build/runtime versions can be a source of problems sometimes... |
|
I think we should also change the CMakeLists file to add the git commit to the app version, only in case of a manual compile (not releases). Otherwise we won't see which commit a user built from. |
|
That should be doable, yeah. We actually do provide that info, but only if we build with We could check if the current commit is tagged and prefixed with |
|
Nice! I like where this is going. @zjeffer there are some lint errors, I believe? |
1c8bf61 to
785474a
Compare
|
Fixed the lint errors by rebasing after merging my fixes PR. I'll look into making the APP_VERSION dynamic when I have some more time. |
Implements #215
Creating a draft PR to get initial review and more ideas on what to add to the parser.
I haven't yet implemented the
count,trash-countandlist-notesoptions, because I'm not sure how we should best handle those. It would require setting up the DBManager inmain.cpp, I guess. We could also just merge without those 3 options, to at least provide a--versionargument.Closes #682