Merged
Conversation
added 2 commits
January 4, 2026 21:32
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Deploying x402-exec with
|
| Latest commit: |
8d1f62e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://393696a7.x402-exec.pages.dev |
| Branch Preview URL: | https://default-to-v2.x402-exec.pages.dev |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes v2 the default and only supported version of the x402 protocol, deprecating v1. It removes the FACILITATOR_ENABLE_V2 feature flag and attempts to implement backward compatibility by defaulting x402Version to 2 when not explicitly provided.
Key changes:
- Remove v2 enablement flag (FACILITATOR_ENABLE_V2) and make v2 always enabled
- Update version detection logic to default x402Version to 2 for backward compatibility
- Exclude e2e tests from default test runs to improve CI/CD performance
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| typescript/packages/facilitator-sdk/vitest.config.ts | Exclude e2e directory from default test runs and update timeout comment |
| typescript/packages/facilitator-sdk/package.json | Bump version to 2.3.1 and update e2e test command to run all e2e tests |
| typescript/packages/extensions/src/facilitator.ts | Add x402Version to top-level request body for verify and settle calls |
| typescript/packages/extensions/package.json | Bump version to 2.3.1 |
| typescript/packages/extensions/package-lock.json | Update lockfile version to 2.3.1 |
| typescript/packages/client/package.json | Bump version to 2.3.1 |
| scripts/publish-x402.sh | Remove entire publish script (185 lines deleted) |
| scripts/publish-packages.sh | Update comments to clarify SDK package testing |
| facilitator/src/routes/verify.ts | Remove enableV2 flag, add version defaulting logic, update documentation |
| facilitator/src/routes/supported.ts | Remove enableV2 flag and simplify v2 availability check |
| facilitator/src/routes/settle.ts | Remove enableV2 flag, add version defaulting logic, update documentation |
| facilitator/src/routes/index.ts | Remove enableV2 flag from route dependencies |
| facilitator/src/router-settlement-service.ts | Remove enableV2 flag and update v2 support logic |
| facilitator/src/network-utils.ts | Remove FACILITATOR_ENABLE_V2 constant and simplify version support check |
| facilitator/src/index.ts | Remove enableV2 flag from configuration |
| facilitator/src/config.ts | Change enabled field to always true and remove conditional v2 enabling logic |
Files not reviewed (1)
- typescript/packages/extensions/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+94
to
+101
| versionDetection: "x402Version is optional (defaults to 2 for backward compatibility)", | ||
| supportedModes: ["v2_router"], | ||
| deprecationNotice: "v1 is deprecated - please use x402Version=2", | ||
| backwardCompatibility: "If x402Version is not provided, defaults to 2", | ||
| body: { | ||
| paymentPayload: "PaymentPayload (with x402Version=2)", | ||
| paymentRequirements: "PaymentRequirements", | ||
| x402Version: "number (required, must be 2)", | ||
| x402Version: "number (optional, defaults to 2, must be 2 if provided)", |
There was a problem hiding this comment.
Documentation claims backward compatibility and that x402Version defaults to 2, but this is inconsistent with the actual validation logic which requires x402Version to be present. The documentation should either be updated to match the strict validation, or the validation logic should be updated to actually support defaulting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.