fix: populate domainLocales based on module config (#3694)

[cjpearson]

🔗 Linked issue

#3694

📚 Description

This ports the change from #3695 to v10.

Summary by CodeRabbit

• Refactor
  • Improved the way locale and domain information is initialized, ensuring the configuration accurately reflects available locales and their associated domains. No changes to public interfaces.

[coderabbitai]

Walkthrough

The initialization of the domainLocales property in the runtime configuration has been updated. Instead of assigning an empty object, the property is now dynamically constructed by iterating over the locales array and mapping each locale to a key-value pair that includes domain information.

Changes

File(s)	Change Summary
src/prepare/runtime-config.ts	Changed domainLocales initialization to dynamically map locales to domain objects based on their type.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant prepareRuntimeConfig
    participant ctx.options.locales

    Caller->>prepareRuntimeConfig: Call with ctx
    prepareRuntimeConfig->>ctx.options.locales: Iterate over locales
    loop For each locale
        prepareRuntimeConfig->>prepareRuntimeConfig: Map locale to { code: { domain } }
    end
    prepareRuntimeConfig-->>Caller: Return config with populated domainLocales

Loading

Possibly related PRs

• fix: locale detection should respect runtime-configured domains (#2931) #3697: Updates locale detection logic to respect runtime-configured domain-to-locale mappings, which depends on how domainLocales is initialized.
• fix: switchLocalePath missing app.baseURL when using differentDomains #3634: Focuses on handling locale domains and base URLs, directly interacting with the structure of domainLocales as set up in runtime config.

Poem

A hop, a leap, a mapping anew—
Locales and domains now paired in view.
No empty shell, but keys with care,
Each locale’s domain, right there!
With every run, the config grows bright—
🐇 Hopping through code, making it right!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3fca87a and 12021df.

📒 Files selected for processing (1)

• src/prepare/runtime-config.ts (1 hunks)

🔇 Additional comments (1)

src/prepare/runtime-config.ts (1)

18-25: LGTM! Excellent fix for populating domainLocales dynamically.

The implementation correctly addresses the PR objective by replacing the static empty object with a dynamic mapping based on the module configuration. The code properly handles both string and object locale formats, uses appropriate null handling with the nullish coalescing operator, and maintains type safety through the assertion.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.