feat: encode reserved characters in URI path#1268
Draft
Conversation
Member
|
I'm opening a new PR as I don't have permission to push to this one: #2005 |
6 tasks
Member
|
@riddla feel free to pull in my commits in the linked branch on nuxt/image into this PR. testing it out in the playground, it doesn't seem to work. I get this error: |
…ved-characters-in-uri-path
commit: |
…ers-in-uri-path' into feat/encode-reserved-characters-in-uri-path
... and update test snapshots for consistency nuxt#2005 (comment)
Author
|
@danielroe, the change in #08fcb23 sorts the parameters in alphabetical order. Which did fix the ipx image not showing up in the playground. But to be honest, I did not fully grasp the underlying issue in ipx, so this pragmatic approach might not be sufficient. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fell into a rabbit hole yesterday analysing why Slack would not show the preview of an
og:image. After a long try and error I discovered that the URIs generated via theipxprovider contains ampersands respectively: the Slackbot needs URIs with encoded reserved characters in the URIs path .With encoded characters (
fit_inside%26f_png%26s_1200x630) the preview came to life.