fix(setup): Setup provider using the provider key#1420
Draft
fix(setup): Setup provider using the provider key#1420
provider key#1420Conversation
Author
|
Drafting this for now as there is some weird things going on with ipx Because we can't use nitro so early |
Member
|
would you be able to add an example of the usage you have in mind, perhaps by adding it to the test fixture? 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Fixes #1414
❓ Type of change
📚 Description
Because the name is user provided and can (and should be different if we have multiple instances of one provider) then any name different than the provider name (eg:
my-remote-ipxinstead ofipx) will not setup the provider as expected