fix(NuxtImg): add image onerror handler in internal script to avoid s…#1884
Draft
bobeatspie wants to merge 1 commit intonuxt:mainfrom
Draft
fix(NuxtImg): add image onerror handler in internal script to avoid s…#1884bobeatspie wants to merge 1 commit intonuxt:mainfrom
bobeatspie wants to merge 1 commit intonuxt:mainfrom
Conversation
…cript-src-attr CSP violation
|
@bobeatspie is attempting to deploy a commit to the NuxtLabs Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
Member
|
the purpose of the inline js is to capture errors that occur before vue has hydrated the page we might also be able to add a script in I've marked as draft for my own triage - feel free to unmark whenever it's ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cript-src-attr CSP violation
🔗 Linked issue
Resolves #1011
❓ Type of change
📚 Description
The CSP header "script-src-attr" prevents inline javascript from executing when the header's value is set to 'none'. By adding the error event handler in the onMounted hook, it becomes easier for Nuxt Security to add a hash to the script and allow the error handler to execute.