Skip to content

fix(types): add ProviderDefaults to fix provider type resolution #2056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kaki0704 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(types): add ProviderDefaults to fix provider type resolution #2056

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a88bda6
fix(types): add ProviderDefaults to fix provider type resolution. res…
kaki0704 Dec 5, 2025
4ebdf91
fix(types): resolve DefaultProvider to configured providers instead o…
kaki0704 Dec 8, 2025
53ed7ec
fix(types): add default provider to ProviderDefaults interface
kaki0704 Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/types/image.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export interface ResolvedImageModifiers extends ImageModifiers {
height: number
}

type DefaultProvider = ProviderDefaults extends Record<'provider', unknown> ? ProviderDefaults['provider'] : never
type DefaultProvider = ProviderDefaults extends Record<'provider', infer P> ? P : keyof ConfiguredImageProviders
Copy link
Member

@danielroe danielroe Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't think this is the right fix - we need to know the specific default provider (likely ipx) in case provider is not passed into any image functions.


export interface ImageOptions<Provider extends keyof ConfiguredImageProviders = DefaultProvider> {
provider?: Provider
Expand Down
Loading