feat(runtime): export Picture and Image props types#2115
feat(runtime): export Picture and Image props types#2115huang-julien wants to merge 3 commits intomainfrom
Conversation
commit: |
📝 WalkthroughWalkthroughAdded two public type exports in Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
would you take a look at the failing tests? |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/runtime/types.ts`:
- Around line 1-2: Remove the leading blank line at the top of the types file
and ensure the file ends with a single trailing newline to satisfy ESLint rules;
update the declaration for the DataAttributes type (export type DataAttributes =
Record<`data-${string}`, string>) so there is no blank line before it and the
file terminates with a newline character.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2115 +/- ##
========================================
+ Coverage 6.83% 6.86% +0.02%
========================================
Files 80 81 +1
Lines 3729 3730 +1
Branches 142 143 +1
========================================
+ Hits 255 256 +1
Misses 3424 3424
Partials 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Deploying nuxt-image with
|
| Latest commit: |
a8df8ec
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://728ee73b.nuxt-image.pages.dev |
| Branch Preview URL: | https://feat-export-props-types.nuxt-image.pages.dev |
🔗 Linked issue
❓ Type of change
📚 Description
this PR exports ImageProps and PictureProps in
@nuxt/image/runtime