Add translator comments for several missing strings#19313
Draft
rrajput22 wants to merge 1 commit intonvaccess:masterfrom
Draft
Add translator comments for several missing strings#19313rrajput22 wants to merge 1 commit intonvaccess:masterfrom
rrajput22 wants to merge 1 commit intonvaccess:masterfrom
Conversation
Member
|
Hi - please make sure that the "check translator comments" test passes |
Member
|
you can do this by modifying tests/checkPot |
Contributor
|
Could you please edit the initial description of this PR to do the following changes:
Do as follows: |
Member
|
Hi @rrajput22 to you intend to work on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Summary of the issue: Several translatable strings in source/controlTypes/role.py were missing translator comments. These strings are listed in tests/checkPot.py under EXPECTED_MESSAGES_WITHOUT_COMMENTS, meaning the NVDA team has specifically identified them as needing comments for proper localization.
Description of user facing changes: No user-facing functional changes. This PR only improves translator guidance for localization teams by adding context comments.
Description of developer facing changes: Added translator comments (#. Translators: …) above several role entries in role.py. These comments help translators understand the meaning and context of UI strings such as “border”, “filler”, “line”, “calendar”, “video”, “audio”, “data item”, and “header item”.
Description of development approach:
Testing strategy:
Known issues with pull request: None. Changes are strictly additive comments and do not impact runtime behavior.
Code Review Checklist: