ref!(math-renderer): modularize image generation to make way for typst#1448
Open
benlubas wants to merge 4 commits intonvim-neorg:mainfrom
Open
ref!(math-renderer): modularize image generation to make way for typst#1448benlubas wants to merge 4 commits intonvim-neorg:mainfrom
benlubas wants to merge 4 commits intonvim-neorg:mainfrom
Conversation
Member
|
question: isn't this a breaking change, given the module name is now different? |
Contributor
Author
|
yes, but the other one hasn't released yet.. and I already forgot that latex rendering existed before my PR to make it better lol. Yea this should maybe be marked breaking |
benlubas
changed the title
benlubas
force-pushed
the
chore/math_renderer
branch
from
0905775 to
ea925c7
Compare
vhyrro
reviewed
Jul 8, 2024
Member
vhyrro
left a comment
vhyrro
left a comment
There was a problem hiding this comment.
Big fan of the changes! Just some things here and there.
benlubas
force-pushed
the
chore/math_renderer
branch
2 times, most recently
from
3288a4c to
085293d
Compare
Member
|
I'll probably keep this for Neorg |
benlubas
force-pushed
the
chore/math_renderer
branch
from
085293d to
3fc936c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More or less what it says on the tin.
Extracts the latex specific image generation code into it's own module, and provides that module as configuration to the (now called) math-renderer. This opens up the possibility of other math renderers, the most notable being typst.
Down the road, the norg file format will hopefully have some standard way of specifying the math language, and then this module can be reworked again to take that into account (and possibly render typst and latex in the same document). But for now, user configuration that allows rendering either latex or typst seems like a good starting point.