Skip to content

Conversation

@gpaulbot
Copy link

@gpaulbot gpaulbot commented Jul 9, 2021

nymea-plugins pull request checklist:

  • Make sure the pull request's title is of format "Plugin name: Add support for xyz" or "New plugin: Plugin name"

  • Did you test the changes on hardware, if not (e.g. absence of required hardware), please mention a person to confirm it has been tested.

  • Did you update the plugin's README.md accordingly?

  • Did you update translations (cd builddir && make lupdate)?

  • If you added a new plugin, should it be added to nymea-plugins-all or nymea-plugins-maker?

@nymea-jenkins
Copy link
Contributor

Can one of the admins verify this patch?

@CLAassistant
Copy link

CLAassistant commented Jul 9, 2021

CLA assistant check
All committers have signed the CLA.

@mzanetti mzanetti added the experimental Branches with this tag will be built in the experimental track label Jul 9, 2021
@mzanetti
Copy link
Contributor

mzanetti commented Jul 9, 2021

Also, please add the dpkg files so it will be packaged by CI:

  • add package in debian/control
  • add debian/nymea-plugin-smartcar.install.in

Not sure if we need to add it to any meta package (last point from checklist), probably not as the vast majority of users out there won't have a supported car yet.

nymea-jenkins added a commit that referenced this pull request Jul 9, 2021
nymea-jenkins added a commit that referenced this pull request Jul 9, 2021
nymea-jenkins added a commit that referenced this pull request Jul 10, 2021
nymea-jenkins added a commit that referenced this pull request Jul 11, 2021
nymea-jenkins added a commit that referenced this pull request Aug 2, 2021
nymea-jenkins added a commit that referenced this pull request Aug 2, 2021
nymea-jenkins added a commit that referenced this pull request Aug 3, 2021
nymea-jenkins added a commit that referenced this pull request Aug 5, 2021
nymea-jenkins added a commit that referenced this pull request Aug 5, 2021
nymea-jenkins added a commit that referenced this pull request Aug 6, 2021
nymea-jenkins added a commit that referenced this pull request Aug 7, 2021
nymea-jenkins added a commit that referenced this pull request Aug 7, 2021
nymea-jenkins added a commit that referenced this pull request Aug 9, 2021
nymea-jenkins added a commit that referenced this pull request Aug 9, 2021
nymea-jenkins added a commit that referenced this pull request Aug 9, 2021
nymea-jenkins added a commit that referenced this pull request Aug 12, 2021
nymea-jenkins added a commit that referenced this pull request Aug 13, 2021
nymea-jenkins added a commit that referenced this pull request Aug 16, 2021
nymea-jenkins added a commit that referenced this pull request Aug 17, 2021
nymea-jenkins added a commit that referenced this pull request Aug 17, 2021
nymea-jenkins added a commit that referenced this pull request Aug 17, 2021
nymea-jenkins added a commit that referenced this pull request Aug 17, 2021
nymea-jenkins added a commit that referenced this pull request Aug 18, 2021
nymea-jenkins added a commit that referenced this pull request Aug 18, 2021
nymea-jenkins added a commit that referenced this pull request Mar 1, 2022
nymea-jenkins added a commit that referenced this pull request Mar 2, 2022
nymea-jenkins added a commit that referenced this pull request Mar 4, 2022
nymea-jenkins added a commit that referenced this pull request Mar 7, 2022
nymea-jenkins added a commit that referenced this pull request Mar 7, 2022
nymea-jenkins added a commit that referenced this pull request Mar 9, 2022
nymea-jenkins added a commit that referenced this pull request Mar 9, 2022
nymea-jenkins added a commit that referenced this pull request Mar 9, 2022
nymea-jenkins added a commit that referenced this pull request Mar 10, 2022
nymea-jenkins added a commit that referenced this pull request Mar 10, 2022
nymea-jenkins added a commit that referenced this pull request Mar 16, 2022
nymea-jenkins added a commit that referenced this pull request Mar 16, 2022
nymea-jenkins added a commit that referenced this pull request Mar 16, 2022
nymea-jenkins added a commit that referenced this pull request Mar 17, 2022
nymea-jenkins added a commit that referenced this pull request Mar 17, 2022
nymea-jenkins added a commit that referenced this pull request Mar 24, 2022
nymea-jenkins added a commit that referenced this pull request Mar 25, 2022
nymea-jenkins added a commit that referenced this pull request Mar 26, 2022
nymea-jenkins added a commit that referenced this pull request Mar 27, 2022
nymea-jenkins added a commit that referenced this pull request Mar 28, 2022
nymea-jenkins added a commit that referenced this pull request Mar 28, 2022
nymea-jenkins pushed a commit that referenced this pull request Mar 30, 2022
nymea-jenkins pushed a commit that referenced this pull request Mar 30, 2022
nymea-jenkins pushed a commit that referenced this pull request Mar 30, 2022
nymea-jenkins pushed a commit that referenced this pull request Mar 30, 2022
nymea-jenkins pushed a commit that referenced this pull request Mar 30, 2022
nymea-jenkins pushed a commit that referenced this pull request Apr 2, 2022
nymea-jenkins pushed a commit that referenced this pull request Apr 4, 2022
nymea-jenkins pushed a commit that referenced this pull request Apr 8, 2022
@mzanetti mzanetti removed the experimental Branches with this tag will be built in the experimental track label Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants