Fix for PanGestureCancelled state#193
Open
eugene-manaev wants to merge 1 commit intonytimes:developfrom
Open
Conversation
Fixes issue, when you trying to dismiss NYTPhotoViewer (being landscape), which presented by portrait-only controller. In that case panGestureRecognizer.state turns to "cancelled". We should treat that state the same way as "ended", because by the fact it ended. Probably, there can be many other cases, which will be fix by this line of code. Can be reproduced: iOS >= 8.0 I can provide video with "steps to reproduce", if you need this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably, there can be many other cases, which will be fix by this line of code.
Fixes issue, when you trying to dismiss NYTPhotoViewer (being landscape), which presented by portrait-only controller. In that case panGestureRecognizer.state turns to "cancelled".
If not to handle this, photo stays with the same frame as on the moment of touch cancellation.
Even if you continue dragging your finger, nothing will be happened, because we lost the touch!
We should treat that state the same way as "ended", because by the fact it ended.
Can be reproduced:
iOS >= 8.0
I can provide video with "steps to reproduce", if you need this.